westonpace commented on code in PR #33775:
URL: https://github.com/apache/arrow/pull/33775#discussion_r1087215277
##########
cpp/src/arrow/compute/kernels/scalar_round.cc:
##########
@@ -906,9 +980,8 @@ void AddNullExec(ScalarFunction* func) {
DCHECK_OK(func->AddKernel(std::move(input_types), OutputType(null()),
NullToNullExec));
}
-template <typename Op, typename FunctionImpl = ArithmeticFunction>
-std::shared_ptr<ScalarFunction> MakeArithmeticFunction(std::string name,
- FunctionDoc doc) {
+template <typename Op, typename FunctionImpl = RoundFunction>
+std::shared_ptr<ScalarFunction> MakeRoundFunction(std::string name,
FunctionDoc doc) {
Review Comment:
You didn't add this but...is this used? I think this file must have been
generated from scalar_arithmetic.cc and not quite cleaned up all the way.
##########
cpp/src/arrow/compute/kernels/scalar_round.cc:
##########
@@ -918,11 +991,11 @@ std::shared_ptr<ScalarFunction>
MakeArithmeticFunction(std::string name,
return func;
}
-// Like MakeArithmeticFunction, but for arithmetic ops that need to run
+// Like MakeRoundFunction, but for arithmetic ops that need to run
// only on non-null output.
-template <typename Op, typename FunctionImpl = ArithmeticFunction>
-std::shared_ptr<ScalarFunction> MakeArithmeticFunctionNotNull(std::string name,
- FunctionDoc doc)
{
+template <typename Op, typename FunctionImpl = RoundFunction>
+std::shared_ptr<ScalarFunction> MakeRoundFunctionNotNull(std::string name,
Review Comment:
Same here. Is this used?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
