melgenek commented on code in PR #5033:
URL: https://github.com/apache/arrow-datafusion/pull/5033#discussion_r1084606028
##########
datafusion/core/tests/sqllogictests/src/main.rs:
##########
@@ -47,13 +47,7 @@ pub async fn main() -> Result<(), Box<dyn Error>> {
let options = Options::new();
- let files: Vec<_> = read_test_files(&options);
-
- info!("Running test files {:?}", files);
-
- for path in files {
- let file_name =
path.file_name().unwrap().to_str().unwrap().to_string();
-
+ for (path, file_name) in read_test_files(&options) {
Review Comment:
`file_name` is technically not a file name here, but
`relative_file_path`/`relative_file_path`/`relative_file_name`.
I haven't changed the name yet, but it could be clearer to explain somehow
that the string is relative to the root directory.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
