melgenek commented on code in PR #5033:
URL: https://github.com/apache/arrow-datafusion/pull/5033#discussion_r1085636090
##########
datafusion/core/tests/sqllogictests/src/engines/postgres/mod.rs:
##########
@@ -188,8 +187,12 @@ fn no_quotes(t: &str) -> &str {
/// Given a file name like pg_compat_foo.slt
/// return a schema name
-fn schema_name(file_name: &str) -> &str {
- file_name
+fn schema_name(relative_path: &Path) -> &str {
+ relative_path
+ .file_name()
+ .unwrap()
Review Comment:
I updated the logic to only keep Ascii characters
https://github.com/apache/arrow-datafusion/pull/5033/commits/93f4ffde681e73a2e8ac0ba6269a7076ef5de236.
I had issues with having numbers in postgres schema, so Ascii chars should be
the safest option.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
