saltgen commented on code in PR #33848:
URL: https://github.com/apache/arrow/pull/33848#discussion_r1085891275
##########
cpp/src/arrow/dataset/discovery.cc:
##########
@@ -244,7 +244,7 @@ Result<std::vector<std::shared_ptr<Schema>>>
FileSystemDatasetFactory::InspectSc
if (ARROW_PREDICT_FALSE(!result.ok())) {
return result.status().WithMessage(
"Error creating dataset. Could not read schema from '", info.path(),
- "': ", result.status().message(), ". Is this a '",
format_->type_name(),
+ "': ", result.status().message(), " Is this a '",
format_->type_name(),
Review Comment:
I agree, I think `()` would help with emphasizing an inner exception.
Additionally, I see file type repeated, may I modify the last line of the
inner exception, like so?
`pyarrow.lib.ArrowInvalid: Error creating dataset. Could not read schema
from 'data/flights-200k.arrow': (Could not open Parquet input source
'data/flights-200k.arrow': Parquet magic bytes not found in footer. This file
might be corrupted.) Is this a 'parquet' file?`
P.S. I might also need to make respective change in the Go component.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
