westonpace commented on code in PR #33848:
URL: https://github.com/apache/arrow/pull/33848#discussion_r1086026982
##########
cpp/src/arrow/dataset/discovery.cc:
##########
@@ -244,7 +244,7 @@ Result<std::vector<std::shared_ptr<Schema>>>
FileSystemDatasetFactory::InspectSc
if (ARROW_PREDICT_FALSE(!result.ok())) {
return result.status().WithMessage(
"Error creating dataset. Could not read schema from '", info.path(),
- "': ", result.status().message(), ". Is this a '",
format_->type_name(),
+ "': ", result.status().message(), " Is this a '",
format_->type_name(),
Review Comment:
Hmm, the inner exception can occur in other contexts too though. For
example, when reading a single parquet file without datasets. In that case the
idea that it might not be a parquet file could be helpful. I think the
double-sentence might be preferred still.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
