xiaoyong-z commented on code in PR #5074:
URL: https://github.com/apache/arrow-datafusion/pull/5074#discussion_r1089729931
##########
datafusion/core/src/physical_plan/projection.rs:
##########
@@ -69,6 +72,13 @@ impl ProjectionExec {
expr: Vec<(Arc<dyn PhysicalExpr>, String)>,
input: Arc<dyn ExecutionPlan>,
) -> Result<Self> {
+ let mut all_column_expr = true;
+ // If expressions are all column_expr, then projection would not
benefit
+ // from the repartition, this is because all computations in this
projection
+ // are reorder or rename.
+ for (e, _) in expr.iter() {
+ all_column_expr &= e.is_column_expr()
+ }
Review Comment:
learn a lot, thanks for your comment!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
