xiaoyong-z commented on PR #5074: URL: https://github.com/apache/arrow-datafusion/pull/5074#issuecomment-1410270517
> Thanks again @xiaoyong-z -- I agree with @ozankabak that we should wait for the fix of #5100 prior to merging this PR so we don't have to disable the tests > > I also think that columns with aliases (e.g. `select column date as close_date`) should not get repartitioned. I confirmed that in the physical expressions, I could not find any alias exprs https://docs.rs/datafusion-physical-expr/16.1.0/datafusion_physical_expr/index.html?search=alias 👍 alias expression itself is also a column_expr, we only need to check whether this expr is a column_expr. I have verified that select column date as close_date will not be repartitioned. <img width="1267" alt="image" src="https://user-images.githubusercontent.com/31178013/215761246-4de79147-f77d-475c-913f-4e5ad6a6190b.png";> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
![https://user-images.githubusercontent.com/31178013/215761246-4de79147-f77d-475c-913f-4e5ad6a6190b.png"](https://user-images.githubusercontent.com/31178013/215761246-4de79147-f77d-475c-913f-4e5ad6a6190b.png"){kind=link}