wjones127 commented on code in PR #33910:
URL: https://github.com/apache/arrow/pull/33910#discussion_r1090925041
##########
cpp/src/parquet/encoding.cc:
##########
@@ -649,15 +649,15 @@ class DictEncoderImpl : public EncoderImpl, virtual
public DictEncoder<DType> {
};
template <typename DType>
-void DictEncoderImpl<DType>::WriteDict(uint8_t* buffer) {
+void DictEncoderImpl<DType>::WriteDict(uint8_t* buffer) const {
Review Comment:
I'm not 100% sure on the C++ conventions here, but I'm not sure I agree this
should be labelled `const`. We are modifying `memo_table_`, right? And probably
doing so in a way that wouldn't be safe to call from multiple threads
concurrently?
@lidavidm Am I wrong on this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
