lidavidm commented on code in PR #33910:
URL: https://github.com/apache/arrow/pull/33910#discussion_r1092067010
##########
cpp/src/parquet/encoding.cc:
##########
@@ -649,15 +649,15 @@ class DictEncoderImpl : public EncoderImpl, virtual
public DictEncoder<DType> {
};
template <typename DType>
-void DictEncoderImpl<DType>::WriteDict(uint8_t* buffer) {
+void DictEncoderImpl<DType>::WriteDict(uint8_t* buffer) const {
Review Comment:
Sorry about that! It's a little unclear that a method called CopyValues
modifies its argument and not itself, but I should've looked more closely.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
