mapleFU commented on code in PR #33776:
URL: https://github.com/apache/arrow/pull/33776#discussion_r1092020113
##########
cpp/src/parquet/bloom_filter.cc:
##########
@@ -146,7 +208,7 @@ bool BlockSplitBloomFilter::FindHash(uint64_t hash) const {
void BlockSplitBloomFilter::InsertHash(uint64_t hash) {
const uint32_t bucket_index =
- static_cast<uint32_t>(hash >> 32) & (num_bytes_ / kBytesPerFilterBlock -
1);
+ static_cast<uint32_t>(((hash >> 32) * (num_bytes_ /
kBytesPerFilterBlock)) >> 32);
uint32_t key = static_cast<uint32_t>(hash);
Review Comment:
Seems not, `Insert` may modify bitset...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
