mapleFU commented on code in PR #33776:
URL: https://github.com/apache/arrow/pull/33776#discussion_r1092065382
##########
cpp/src/parquet/bloom_filter_test.cc:
##########
@@ -242,6 +236,77 @@ TEST(OptimalValueTest, TestBloomFilter) {
UINT32_C(1073741824));
}
+int64_t HASHES_OF_LOOPING_BYTES_WITH_SEED_0[32] = {
Review Comment:
> Well, we don't need to copy blindly what parquet-mr does :-)
I think it's correct and standard, and it will be too long, just copying
this piece of code is much trustworthy than hello world and different seed...
##########
cpp/src/parquet/bloom_filter_test.cc:
##########
@@ -242,6 +236,77 @@ TEST(OptimalValueTest, TestBloomFilter) {
UINT32_C(1073741824));
}
+int64_t HASHES_OF_LOOPING_BYTES_WITH_SEED_0[32] = {
Review Comment:
> Well, we don't need to copy blindly what parquet-mr does :-)
I think it's correct and standard, and it will not be too long, just copying
this piece of code is much trustworthy than hello world and different seed...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
