ianmcook opened a new issue, #33956:
URL: https://github.com/apache/arrow/issues/33956

   ### Describe the enhancement requested
   
   The example at 
[cpp/examples/arrow/engine_substrait_consumption.cc](https://github.com/apache/arrow/blob/master/cpp/examples/arrow/engine_substrait_consumption.cc)
 has some shortcomings that make it less useful than it could be for 
demonstrating how Acero can consume and execute Substrait plans: 
   
   - It does not collect the result into a table and display it (which is quite 
disappointing after one struggles to get the example running)
   - The `add` function is included in the extensions but not used
   - The extension references and anchors are silly
   - Some of the code and comments seems to conflate the terms "consume" (which 
should apply to a plan) and "sink" (which should apply to data)
   - The user needs to find/create a Parquet file to run it
   - `#include <arrow/engine/api.h>` needs to be changed to `#include 
<arrow/engine/substrait/api.h>`
   
   ### Component(s)
   
   C++


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to