pitrou commented on code in PR #33846:
URL: https://github.com/apache/arrow/pull/33846#discussion_r1092215584
##########
cpp/src/arrow/compute/kernels/vector_sort_test.cc:
##########
@@ -1962,15 +1962,50 @@ INSTANTIATE_TEST_SUITE_P(AllNull,
TestTableSortIndicesRandom,
// ----------------------------------------------------------------------
// Tests for Rank
-void AssertRank(const std::shared_ptr<Array>& input, SortOrder order,
- NullPlacement null_placement, RankOptions::Tiebreaker
tiebreaker,
+struct RankTestCase {
Review Comment:
Hmm... sorry to bother you with this, but it would be more idiomatic to use
a GTest fixture (i.e. a class derived from `::testing::Test`).
You could have something like:
```c++
class TestRank : public ::testing::Test {
public:
void SetInput(const std::shared_ptr<Array>& array) {
...
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
