westonpace commented on PR #33909: URL: https://github.com/apache/arrow/pull/33909#issuecomment-1412923038
> @westonpace, in the [recent commit](https://github.com/apache/arrow/pull/33909/commits/65542c3cbbe28228d8105ab49430a9b3844a77d5), when coding up kDefaultNamedTapKindMapper, I reused the code structure for kDefaultNamedTableProvider. However, it looks like it is not properly initialized - I observed the error message C++ exception with description "bad_function_call" thrown in the test body when calling its operator(). Is this intended? Or shall I fix the initialization of both? What would you initialize it to? There is no default named table provider. I'm pretty sure we are using `kDefaultNamedTapKindMapper` as sentinel value only. Since `std::function` evaluates to false if default initialized: ``` if (!conversion_options.named_table_provider) { return Status::Invalid( "plan contained a named table but a NamedTableProvider has not been " "configured"); } ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
