westonpace commented on PR #33909: URL: https://github.com/apache/arrow/pull/33909#issuecomment-1412924919
> Note that the factory registry does not support scoping, which could be useful for cleaning up after and isolating testing (here, due to AddPassFactory) and in other use cases, like with other scoped registries. @westonpace, do you agree? open an issue? I'm not opposed to this but I don't think it is really necessary. The tests all rely on the fact that the initialization methods are setup as "call-once" so calling them repeatedly won't be a problem. When dealing with the function registry it seemed important to support nested registries because you might have query-specific functions (e.g. if a UDF is embedded this could be one way to handle it). However, the odds of having query-specific nodes seems pretty slim to me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
