pitrou commented on code in PR #33886:
URL: https://github.com/apache/arrow/pull/33886#discussion_r1094239133
##########
cpp/src/arrow/compute/kernels/vector_sort_test.cc:
##########
@@ -45,6 +45,15 @@ using internal::checked_pointer_cast;
namespace compute {
+#ifdef ARROW_VALGRIND
+using RealArrowTypes = ::testing::Types<FloatType>;
Review Comment:
Ah, I didn't know you could redefine an alias with `using`.
As a style note, I would personally prefer if this created a distinct alias,
to avoid confusion - and potential leaking accross unity builds?
(e.g. replace `RealArrowTypes` with `RealSortTypes` or something)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
