icexelloss commented on code in PR #33909:
URL: https://github.com/apache/arrow/pull/33909#discussion_r1095054111
##########
cpp/src/arrow/engine/substrait/options.h:
##########
@@ -83,6 +84,14 @@ class ARROW_ENGINE_EXPORT ExtensionProvider {
ARROW_ENGINE_EXPORT std::shared_ptr<ExtensionProvider>
default_extension_provider();
+struct ARROW_ENGINE_EXPORT NamedTapNodeOptions : public
compute::ExecNodeOptions {
+ NamedTapNodeOptions(const std::string& name, std::shared_ptr<Schema> schema)
+ : name(name), schema(std::move(schema)) {}
+
+ std::string name;
+ std::shared_ptr<Schema> schema;
+};
Review Comment:
IMO I don't think this is over generalized - it matches the level of
generalization in substrait extension protobuf - Leaf, single rel and multiple
rel. As something experimental at this stage I think we do benefit from
generalization since we make very minimal changes to Acero code itself and have
more freedom to experiment / iterate faster on our side.
And if we have https://github.com/apache/arrow/issues/33850, then I think we
don't need `kDefaultNamedTapKindMapper` and feels to me it's a simpler single
extension point.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
