icexelloss commented on code in PR #33909:
URL: https://github.com/apache/arrow/pull/33909#discussion_r1095061363
##########
cpp/src/arrow/engine/substrait/options.h:
##########
@@ -67,6 +68,10 @@ using NamedTableProvider =
std::function<Result<compute::Declaration>(const
std::vector<std::string>&)>;
static NamedTableProvider kDefaultNamedTableProvider;
+using NamedTapKindMapper = std::function<Result<std::string>(const
std::string&)>;
+static NamedTapKindMapper kDefaultNamedTapKindMapper =
Review Comment:
If you wanted to add this, I think we should probably match the signature of
kDefaultNamedTableProvider and returns a Declaration instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
