westonpace commented on code in PR #33909:
URL: https://github.com/apache/arrow/pull/33909#discussion_r1096055349
##########
cpp/proto/substrait/extension_rels.proto:
##########
@@ -44,3 +44,17 @@ message AsOfJoinRel {
repeated .substrait.Expression by = 2;
}
}
+
+// Named tap relation
+//
+// A tap is a relation having a single input relation that it passes through,
while also
+// causing some side-effect, e.g., writing to external storage.
+message NamedTapRel {
+ // The kind of tap
+ string kind = 1;
+ // A name used to configure the tap, e.g., a URI defining the destination of
writing
+ string name = 2;
+ // Column names for the tap's output. If specified there must be one name
per field.
+ // If empty, field names will be automatically generated.
Review Comment:
I have no strong opinion on this either. I do agree there will be cases
where the tap doesn't care about the names but forcing the producer to invent
field names in this case isn't much burden.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
