westonpace commented on code in PR #33909:
URL: https://github.com/apache/arrow/pull/33909#discussion_r1102867955
##########
cpp/src/arrow/engine/substrait/options.cc:
##########
@@ -129,5 +175,28 @@ std::shared_ptr<ExtensionProvider>
default_extension_provider() {
return ExtensionProvider::kDefaultExtensionProvider;
}
+namespace {
+
+NamedTapProvider g_default_named_tap_provider =
+ [](const std::string& tap_kind, std::vector<compute::Declaration::Input>
inputs,
+ const std::string& tap_name,
+ std::shared_ptr<Schema> tap_schema) -> Result<compute::Declaration> {
+ return Status::NotImplemented("Named tap provider must be given");
Review Comment:
```suggestion
return Status::NotImplemented("Plan contained a NamedTapRel but no
provider configured");
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
