jychen7 commented on code in PR #3663:
URL: https://github.com/apache/arrow-rs/pull/3663#discussion_r1096900042


##########
object_store/src/path/mod.rs:
##########
@@ -162,6 +162,13 @@ impl Path {
         })
     }
 
+    /// Parse a url encoded string as a [`Path`], returning a [`Error`] if 
invalid,
+    /// as defined on the docstring for [`Path`]
+    pub fn from_url_path(path: impl AsRef<str>) -> Result<Self, Error> {
+        let decoded_path = 
percent_encoding::percent_decode_str(path.as_ref()).decode_utf8_lossy();

Review Comment:
   done at d14135d3c1b6e2062c48827e3a91f75e4199f4fa
   
   actually, existing code also have place to percent_decode and capture 
NonUnicodeSnafu, so I just reuse it



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to