jychen7 commented on code in PR #3663:
URL: https://github.com/apache/arrow-rs/pull/3663#discussion_r1096900908
##########
object_store/src/path/mod.rs:
##########
@@ -162,6 +162,13 @@ impl Path {
})
}
+ /// Parse a url encoded string as a [`Path`], returning a [`Error`] if
invalid,
+ /// as defined on the docstring for [`Path`]
+ pub fn from_url_path(path: impl AsRef<str>) -> Result<Self, Error> {
Review Comment:
turn out existing code have
https://github.com/apache/arrow-rs/blob/d14135d3c1b6e2062c48827e3a91f75e4199f4fa/object_store/src/path/mod.rs#L197-L210
so do you think it makes more sense to use `from_url_path(&str)`?
d14135d3c1b6e2062c48827e3a91f75e4199f4fa
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
