lidavidm commented on code in PR #417:
URL: https://github.com/apache/arrow-adbc/pull/417#discussion_r1097335088
##########
adbc.h:
##########
@@ -646,16 +646,16 @@ struct ADBC_EXPORT AdbcDriver {
AdbcStatusCode (*ConnectionRelease)(struct AdbcConnection*, struct
AdbcError*);
AdbcStatusCode (*ConnectionRollback)(struct AdbcConnection*, struct
AdbcError*);
- AdbcStatusCode (*StatementBind)(struct AdbcStatement*, struct ArrowArray*,
- struct ArrowSchema*, struct AdbcError*);
+ AdbcStatusCode (*StatementBind)(struct AdbcStatement*, struct ArrowArray
const*,
+ struct ArrowSchema const*, struct
AdbcError*);
Review Comment:
Binding should probably clear these structs since the statement is expected
to take ownership
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
