lidavidm commented on code in PR #417: URL: https://github.com/apache/arrow-adbc/pull/417#discussion_r1097580658
########## adbc.h: ########## @@ -796,7 +797,7 @@ AdbcStatusCode AdbcConnectionRelease(struct AdbcConnection* connection, /// \param[out] error Error details, if an error occurs. ADBC_EXPORT AdbcStatusCode AdbcConnectionGetInfo(struct AdbcConnection* connection, - uint32_t* info_codes, size_t info_codes_length, + const uint32_t* info_codes, size_t info_codes_length, Review Comment: I think we could probably accept this, even if it's technically a break ########## adbc.h: ########## @@ -903,12 +904,10 @@ AdbcStatusCode AdbcConnectionGetInfo(struct AdbcConnection* connection, /// \param[out] out The result set. /// \param[out] error Error details, if an error occurs. ADBC_EXPORT -AdbcStatusCode AdbcConnectionGetObjects(struct AdbcConnection* connection, int depth, - const char* catalog, const char* db_schema, - const char* table_name, const char** table_type, - const char* column_name, - struct ArrowArrayStream* out, - struct AdbcError* error); +AdbcStatusCode AdbcConnectionGetObjects( + struct AdbcConnection* connection, int depth, const char* catalog, + const char* db_schema, const char* table_name, char const* const* table_type, Review Comment: To be frank I'm not sure I often see the constness declared at this fine-grained of a level ########## adbc.h: ########## @@ -1139,7 +1139,7 @@ AdbcStatusCode AdbcStatementBindStream(struct AdbcStatement* statement, /// /// \return ADBC_STATUS_NOT_IMPLEMENTED if the schema cannot be determined. ADBC_EXPORT -AdbcStatusCode AdbcStatementGetParameterSchema(struct AdbcStatement* statement, +AdbcStatusCode AdbcStatementGetParameterSchema(const struct AdbcStatement* statement, Review Comment: I think it's simpler to let all 'methods' mutate their objects even if it seems like there's no reason to -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
