westonpace commented on code in PR #34042:
URL: https://github.com/apache/arrow/pull/34042#discussion_r1097879089
##########
cpp/src/arrow/engine/substrait/options.cc:
##########
@@ -122,11 +122,23 @@ class DefaultExtensionProvider : public
BaseExtensionProvider {
}
};
-std::shared_ptr<ExtensionProvider>
ExtensionProvider::kDefaultExtensionProvider =
+namespace {
+
+std::shared_ptr<ExtensionProvider> kDefaultExtensionProvider =
std::make_shared<DefaultExtensionProvider>();
+std::mutex kDefaultExtensionProviderMutex;
Review Comment:
```suggestion
std::shared_ptr<ExtensionProvider> default_extension_provider =
std::make_shared<DefaultExtensionProvider>();
std::mutex default_extension_provider_mutex;
```
These aren't constants so we can't use `kName`. Will this work?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
