rtpsw commented on code in PR #34042:
URL: https://github.com/apache/arrow/pull/34042#discussion_r1097911741
##########
cpp/src/arrow/engine/substrait/options.cc:
##########
@@ -122,11 +122,23 @@ class DefaultExtensionProvider : public
BaseExtensionProvider {
}
};
-std::shared_ptr<ExtensionProvider>
ExtensionProvider::kDefaultExtensionProvider =
+namespace {
+
+std::shared_ptr<ExtensionProvider> kDefaultExtensionProvider =
std::make_shared<DefaultExtensionProvider>();
+std::mutex kDefaultExtensionProviderMutex;
Review Comment:
You're right we can't use `kName`. I believe the right way to use is
`g_name`, which I just used in the recent commit.
##########
cpp/src/arrow/engine/substrait/options.cc:
##########
@@ -122,11 +122,23 @@ class DefaultExtensionProvider : public
BaseExtensionProvider {
}
};
-std::shared_ptr<ExtensionProvider>
ExtensionProvider::kDefaultExtensionProvider =
+namespace {
+
+std::shared_ptr<ExtensionProvider> kDefaultExtensionProvider =
std::make_shared<DefaultExtensionProvider>();
+std::mutex kDefaultExtensionProviderMutex;
Review Comment:
You're right we can't use `kName`. I believe the right way is to use
`g_name`, which I just used in the recent commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
