liukun4515 commented on code in PR #5156:
URL: https://github.com/apache/arrow-datafusion/pull/5156#discussion_r1098336445
##########
datafusion/core/src/physical_plan/joins/nested_loop_join.rs:
##########
@@ -304,6 +280,14 @@ async fn load_left_specified_partition(
Ok(merged_batch)
}
+// BuildLeft means the left relation is the single patrition side.
+// For full join, both side are single partition, so it is BuildLeft and
BuildRight, treat it as BuildLeft.
+pub fn left_is_build_side(join_type: JoinType) -> bool {
Review Comment:
if I‘m right, this part is the most important insight for your fix.
If the left can be the single partition, we will iter the right
table/partition
If the right is the single partition, we will iter the left table/partition
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
