liukun4515 commented on code in PR #5156: URL: https://github.com/apache/arrow-datafusion/pull/5156#discussion_r1098337736
########## datafusion/core/src/physical_plan/joins/nested_loop_join.rs: ########## @@ -352,24 +337,22 @@ fn build_join_indices( } impl NestedLoopJoinStream { - fn poll_next_impl( + // For Inner/Left/LeftSemi/LeftAnti joins, left is the single partition side. Review Comment: maybe we should add `full` join type. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org