ktf commented on code in PR #34069: URL: https://github.com/apache/arrow/pull/34069#discussion_r1098498199
########## cpp/src/gandiva/function_registry_math_ops.cc: ########## @@ -62,11 +73,16 @@ namespace gandiva { std::vector<NativeFunction> GetMathOpsFunctionRegistry() { static std::vector<NativeFunction> math_fn_registry_ = { MATH_UNARY_OPS(cbrt, {}), MATH_UNARY_OPS(exp, {}), MATH_UNARY_OPS(log, {}), - MATH_UNARY_OPS(log10, {}), + MATH_UNARY_OPS(log10, {}), MATH_UNARY_OPS(sqrt, {}), Review Comment: Sorry about that, I think I made a mess with the rebase. I will push an updated commit soon. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org