kou commented on PR #34069:
URL: https://github.com/apache/arrow/pull/34069#issuecomment-1421423594

   This pull request includes multiple logical changes:
   
   > * Additional native functions for float32 in Gandiva
   > * Extend bitwise operations for more int types
   > * Adapt to upstream trigonometric function definitions
   > * Prevent clash with c++ variant
   
   Could you split this pull request to multiple small pull requests for each 
logical change?
   Could you also split #34068 to corresponding subissues like #33982?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to