vibhatha commented on code in PR #33753:
URL: https://github.com/apache/arrow/pull/33753#discussion_r1099667174
##########
cpp/src/arrow/dataset/file_base.h:
##########
@@ -450,20 +465,25 @@ struct ARROW_DS_EXPORT FileSystemDatasetWriteOptions {
};
const std::shared_ptr<FileFormat>& format() const {
- return file_write_options->format();
+ return file_write_options_->format();
}
Review Comment:
I think we cannot have `format` as a public attribute and a method with
`format()`, right? That's why I kept using the method. With this new
modification, may be we can get rid of the `format()` function
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
