vibhatha commented on code in PR #33753:
URL: https://github.com/apache/arrow/pull/33753#discussion_r1099754247
##########
cpp/src/arrow/dataset/file_base.h:
##########
@@ -280,7 +281,7 @@ class ARROW_DS_EXPORT FileSystemDataset : public Dataset {
std::shared_ptr<Partitioning> partitioning = NULLPTR);
/// \brief Write a dataset.
- static Status Write(const FileSystemDatasetWriteOptions& write_options,
+ static Status Write(const std::shared_ptr<FileSystemDatasetWriteOptions>&
write_options,
Review Comment:
From the offline discussion, decided to revert this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
