Jefffrey commented on code in PR #5210:
URL: https://github.com/apache/arrow-datafusion/pull/5210#discussion_r1099842534
##########
datafusion/expr/src/logical_plan/builder.rs:
##########
@@ -502,6 +505,25 @@ impl LogicalPlanBuilder {
));
}
+ let filter = if let Some(expr) = filter {
+ // ambiguous check
+ ensure_any_column_reference_is_unambiguous(
+ &expr,
+ &[self.schema(), right.schema()],
+ )?;
+
+ // normalize all columns in expression
+ let using_columns = expr.to_columns()?;
+ let filter = normalize_col_with_schemas(
+ expr,
+ &[self.schema(), right.schema()],
+ &[using_columns],
+ )?;
+ Some(filter)
+ } else {
+ None
+ };
+
Review Comment:
test added
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
