Jefffrey commented on code in PR #5210:
URL: https://github.com/apache/arrow-datafusion/pull/5210#discussion_r1099845204
##########
datafusion/core/src/dataframe.rs:
##########
@@ -1039,6 +1088,33 @@ mod tests {
Ok(())
}
+ #[tokio::test]
+ async fn join_on() -> Result<()> {
+ let left = test_table_with_name("a")
+ .await?
+ .select_columns(&["c1", "c2"])?;
+ let right = test_table_with_name("b")
+ .await?
+ .select_columns(&["c1", "c2"])?;
+ let join = left.join_on(
+ right,
+ JoinType::Inner,
+ [
+ col("a.c1").not_eq(col("b.c1")),
+ col("a.c2").not_eq(col("b.c2")),
Review Comment:
done as you suggested. it seems they still are considered as part of the
filter, though this seems to track with the explicit SQL version too:
https://github.com/apache/arrow-datafusion/blob/f0c67193a3d18ff1d94f9dd55bfb1715e5473bf1/datafusion/sql/tests/integration_test.rs#L1661-L1672
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
