liukun4515 commented on code in PR #5156:
URL: https://github.com/apache/arrow-datafusion/pull/5156#discussion_r1100072020
##########
datafusion/core/src/physical_plan/joins/nested_loop_join.rs:
##########
@@ -352,24 +337,22 @@ fn build_join_indices(
}
impl NestedLoopJoinStream {
- fn poll_next_impl(
+ // For Inner/Left/LeftSemi/LeftAnti joins, left is the single partition
side.
Review Comment:
> The meaning of the comment is opposite 🤣.
>
yes, I also ignore this and just remember the missing type of `Full`.
Thanks for your reminder and point out the mistake of the comments.
👍
> When left is collected to a single partition, the join type should be
`Right/RightSemi/RightAnti/Full`.
>
> Fixed it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
