[GitHub] [arrow-datafusion] jackwener commented on a diff in pull request #5156: Always wrapping OnceAsync for the inner table side in NestedLoopJoinExec

[via GitHub]

jackwener commented on code in PR #5156:
URL: https://github.com/apache/arrow-datafusion/pull/5156#discussion_r1102260244


##########
datafusion/core/src/physical_plan/joins/nested_loop_join.rs:
##########
@@ -312,11 +315,11 @@ struct NestedLoopJoinStream {
     filter: Option<JoinFilter>,
     /// type of the join
     join_type: JoinType,
-    /// future for data from left side
-    left_fut: OnceFut<JoinLeftData>,
-    /// right
-    right: SendableRecordBatchStream,
-    /// There is nothing to process anymore and left side is processed in case 
of left/left semi/left anti/full join
+    // the outer table data of the nested loop join
+    outer_table: SendableRecordBatchStream,
+    // the inner table data of the nested loop join

Review Comment:
   Small problem, should keep same format with other comments
   ```suggestion
       /// the inner table data of the nested loop join
   ```



##########
datafusion/core/src/physical_plan/joins/nested_loop_join.rs:
##########
@@ -312,11 +315,11 @@ struct NestedLoopJoinStream {
     filter: Option<JoinFilter>,
     /// type of the join
     join_type: JoinType,
-    /// future for data from left side
-    left_fut: OnceFut<JoinLeftData>,
-    /// right
-    right: SendableRecordBatchStream,
-    /// There is nothing to process anymore and left side is processed in case 
of left/left semi/left anti/full join
+    // the outer table data of the nested loop join

Review Comment:
   ```suggestion
       /// the outer table data of the nested loop join
   ```



##########
datafusion/core/src/physical_plan/joins/nested_loop_join.rs:
##########
@@ -312,11 +315,11 @@ struct NestedLoopJoinStream {
     filter: Option<JoinFilter>,
     /// type of the join
     join_type: JoinType,
-    /// future for data from left side
-    left_fut: OnceFut<JoinLeftData>,
-    /// right
-    right: SendableRecordBatchStream,
-    /// There is nothing to process anymore and left side is processed in case 
of left/left semi/left anti/full join
+    // the outer table data of the nested loop join

Review Comment:
   ```suggestion
       /// the outer table data of the nested loop join
   ```



##########
datafusion/core/src/physical_plan/joins/utils.rs:
##########
@@ -917,6 +917,23 @@ pub(crate) fn get_anti_indices(
         .collect::<UInt32Array>()
 }
 
+/// Get unmatched and deduplicated indices
+pub(crate) fn get_anti_u64_indices(

Review Comment:
   Could we merge `get_anti_u64_indices/get_semi_u64_indices` into one function?
   Because they are almost the same except `(!bitmap.get_bit(idx))`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org