kou commented on code in PR #34048:
URL: https://github.com/apache/arrow/pull/34048#discussion_r1101043112
##########
ci/scripts/r_install_system_dependencies.sh:
##########
@@ -37,10 +37,10 @@ if [ "$ARROW_S3" == "ON" ] || [ "$ARROW_GCS" == "ON" ] || [
"$ARROW_R_DEV" == "T
# Install curl and OpenSSL for S3/GCS support
case "$PACKAGE_MANAGER" in
apt-get)
- apt-get install -y libcurl4-openssl-dev libssl-dev
+ apt-get install -y libcurl4-openssl-dev libssl-dev pkg-config
Review Comment:
> I'd rather ship a binary that just works. Would it be terrible to grep for
the CXX11_ABI in arrow.pc and add it to `PKG_CFLAGS`?
It will work. I've added the logic but I'm afraid of increasing ad-hoc
logics again.
> If we were to set `LIBARROW_BINARY=false` if no pkg-config, it should be
in its own `"${PKG_CONFIG_AVAILABLE}" = "false"` check, not connected to
whatever the value of `ARROW_DEPENDENCY_SOURCE` is since that's about building
libarrow from source.
It makes sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
