nealrichardson commented on code in PR #34100: URL: https://github.com/apache/arrow/pull/34100#discussion_r1101678867
########## cpp/cmake_modules/ThirdpartyToolchain.cmake: ########## @@ -1057,7 +1057,11 @@ macro(build_boost) set(BOOST_VENDORED TRUE) endmacro() -if(ARROW_BUILD_TESTS) +if(CMAKE_CXX_COMPILER_ID STREQUAL "Clang" AND CMAKE_CXX_COMPILER_VERSION + VERSION_GREATER_EQUAL 16) + # GH-34094 we require newer Boost versions for Clang 16 or newer Review Comment: I'd add another comment line about how older boost versions use the long-deprecated std::unary_function in boost/container_hash/hash.hpp and that support has been removed from clang 16. That way we know why this is here and under what conditions we can remove it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
