[GitHub] [arrow] nealrichardson commented on a diff in pull request #34100: GH-34094: [C++] Increase Boost minimum version for clang >= 16

Thu, 09 Feb 2023 13:17:29 -0800 


nealrichardson commented on code in PR #34100:
URL: https://github.com/apache/arrow/pull/34100#discussion_r1102032963


##########
cpp/cmake_modules/ThirdpartyToolchain.cmake:
##########
@@ -1057,7 +1057,12 @@ macro(build_boost)
   set(BOOST_VENDORED TRUE)
 endmacro()
 
-if(ARROW_BUILD_TESTS)
+if(CMAKE_CXX_COMPILER_ID STREQUAL "Clang" AND CMAKE_CXX_COMPILER_VERSION
+                                              VERSION_GREATER_EQUAL 16)

Review Comment:
   How about this then?
   
   ```suggestion
                                                 VERSION_GREATER 15)
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to