felipecrv commented on code in PR #33641:
URL: https://github.com/apache/arrow/pull/33641#discussion_r1104718606
##########
cpp/src/arrow/array/array_dict_test.cc:
##########
@@ -1117,12 +1117,12 @@ TEST(TestDictionary, Validate) {
arr = std::make_shared<DictionaryArray>(dict_type, indices,
MakeArray(invalid_data));
ASSERT_RAISES(Invalid, arr->ValidateFull());
- ASSERT_DEATH(
- {
- std::shared_ptr<Array> null_dict_arr =
- std::make_shared<DictionaryArray>(dict_type, indices, nullptr);
- },
- "");
+ // ASSERT_DEATH(
+ // {
+ // std::shared_ptr<Array> null_dict_arr =
+ // std::make_shared<DictionaryArray>(dict_type, indices,
nullptr);
+ // },
+ // "");
Review Comment:
It's part of a single commit I pushed to investigate a CI issue
```
Author: Felipe Oliveira Carvalho <[email protected]>
AuthorDate: Wed Feb 8 10:13:17 2023 -0300
Commit: Felipe Oliveira Carvalho <[email protected]>
CommitDate: Mon Feb 13 13:24:47 2023 -0300
TEMPORARY: Comment-out ASSERT_DEATH
diff --git a/cpp/src/arrow/array/array_dict_test.cc
b/cpp/src/arrow/array/array_dict_test.cc
index bfa732f16..d1e109c90 100644
--- a/cpp/src/arrow/array/array_dict_test.cc
+++ b/cpp/src/arrow/array/array_dict_test.cc
@@ -1117,12 +1117,12 @@ TEST(TestDictionary, Validate) {
arr = std::make_shared<DictionaryArray>(dict_type, indices,
MakeArray(invalid_data));
ASSERT_RAISES(Invalid, arr->ValidateFull());
- ASSERT_DEATH(
- {
- std::shared_ptr<Array> null_dict_arr =
- std::make_shared<DictionaryArray>(dict_type, indices, nullptr);
- },
- "");
+ // ASSERT_DEATH(
+ // {
+ // std::shared_ptr<Array> null_dict_arr =
+ // std::make_shared<DictionaryArray>(dict_type, indices,
nullptr);
+ // },
+ // "");
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
