felipecrv commented on code in PR #33641:
URL: https://github.com/apache/arrow/pull/33641#discussion_r1109017564
##########
cpp/src/arrow/array/array_test.cc:
##########
@@ -375,8 +375,9 @@ TEST_F(TestArray, TestMakeArrayOfNull) {
ASSERT_EQ(array->type(), type);
ASSERT_OK(array->ValidateFull());
ASSERT_EQ(array->length(), length);
- if (is_union(type->id())) {
- // For unions, MakeArrayOfNull places the nulls in the children
+ if (is_union(type->id()) || type->id() == Type::RUN_END_ENCODED) {
+ // For unions and run-end encoded, MakeArrayOfNull places the nulls in
the
+ // children
Review Comment:
I thought about this, but couldn't come up with a good name for this
abstract notion. `is_no_top_level_null` ???
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
