felipecrv commented on code in PR #34185:
URL: https://github.com/apache/arrow/pull/34185#discussion_r1107278915
##########
cpp/cmake_modules/ThirdpartyToolchain.cmake:
##########
@@ -2292,6 +2292,7 @@ macro(build_benchmark)
file(MAKE_DIRECTORY "${GBENCHMARK_INCLUDE_DIR}")
add_library(benchmark::benchmark STATIC IMPORTED)
+ target_compile_definitions(benchmark::benchmark INTERFACE
BENCHMARK_STATIC_DEFINE)
Review Comment:
My previous attempt at this change mistakenly deleted a crucial line. :sweat:
Fingers crossed that this will fix the MSVC issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
