kou commented on PR #34185:
URL: https://github.com/apache/arrow/pull/34185#issuecomment-1431931617

   I think that we should not mix `memory_pool_jemalloc.cc` to other sources 
instead of `#undef`:
   
   ```diff
   diff --git a/cpp/src/arrow/CMakeLists.txt b/cpp/src/arrow/CMakeLists.txt
   index 6382fdfb3a..33cf3d396d 100644
   --- a/cpp/src/arrow/CMakeLists.txt
   +++ b/cpp/src/arrow/CMakeLists.txt
   @@ -243,6 +243,8 @@ set(ARROW_SRCS
    
    if(ARROW_JEMALLOC)
      list(APPEND ARROW_SRCS memory_pool_jemalloc.cc)
   +  set_source_files_properties(memory_pool_jemalloc.cc
   +                              PROPERTIES SKIP_UNITY_BUILD_INCLUSION ON)
    endif()
    
    append_avx2_src(util/bpacking_avx2.cc)
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to