westonpace commented on code in PR #34156:
URL: https://github.com/apache/arrow/pull/34156#discussion_r1110085197
##########
python/pyarrow/substrait.py:
##########
@@ -18,4 +18,5 @@
from pyarrow._substrait import ( # noqa
get_supported_functions,
run_query,
+ _check_conversion_options,
Review Comment:
```suggestion
```
##########
python/pyarrow/tests/test_substrait.py:
##########
@@ -34,6 +34,10 @@
pytestmark = [pytest.mark.dataset, pytest.mark.substrait]
+def test_conversion_options():
+ assert substrait._check_conversion_options()
+
+
Review Comment:
```suggestion
```
##########
python/pyarrow/_substrait.pyx:
##########
@@ -26,6 +27,13 @@ from pyarrow.includes.libarrow cimport *
from pyarrow.includes.libarrow_substrait cimport *
+def _check_conversion_options():
+ cdef:
+ CConversionOptions conv_opts
+
+ return conv_opts.strictness == BEST_EFFORT
+
+
Review Comment:
```suggestion
```
Let's get rid of this. It'll just confuse future maintainers more than it
helps I think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
