rtpsw commented on code in PR #34156:
URL: https://github.com/apache/arrow/pull/34156#discussion_r1107223003
##########
python/pyarrow/includes/libarrow_substrait.pxd:
##########
@@ -34,10 +51,27 @@ cdef extern from "arrow/engine/substrait/options.h"
namespace "arrow::engine" no
BEST_EFFORT \
"arrow::engine::ConversionStrictness::BEST_EFFORT"
+ cdef cppclass CExtensionDetails \
+ "arrow::engine::ExtensionDetails"
+
+ cdef cppclass CExtensionProvider \
+ "arrow::engine::ExtensionProvider":
+ CResult[CRelationInfo] MakeRel(
+ const CConversionOptions conv_opts,
+ const vector[CDeclarationInfo]& inputs,
+ const CExtensionDetails& ext_details,
+ const CExtensionSet& ext_set)
+
+ cdef shared_ptr[CExtensionProvider] default_extension_provider()
+ cdef void set_default_extension_provider(
+ const shared_ptr[CExtensionProvider]& provider)
+
cdef cppclass CConversionOptions \
"arrow::engine::ConversionOptions":
+ CConversionOptions()
ConversionStrictness conversion_strictness
function[CNamedTableProvider] named_table_provider
Review Comment:
This doesn't trigger an error, and this is expected. Cython doesn't care if
a symbol exists in C++ but is not exposed in a `pxd`. This allows symbols in a
`pxd` to be included on a need-basis. If you'd like this symbol to be exposed,
I could add (and touch) it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
