korowa opened a new pull request, #5339:
URL: https://github.com/apache/arrow-datafusion/pull/5339
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases. You can
link an issue to this PR using the GitHub syntax. For example `Closes #123`
indicates that this PR will close issue #123.
-->
Closes #5162.
Part of #5220.
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in
the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your
changes and offer better suggestions for fixes.
-->
Memory management for at least on Join operator
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is
sometimes worth providing a summary of the individual changes in this PR.
-->
- `CrossJoinExec.reservation` -- the actual reservation, used in
`load_left_input` closure to reserve memory for build-side data, and in stream
polling function to free memory after probe-side stream has been exhausted.
Another point where memory gets freed is a destructor of reservation (i.e. in
case when parent operator has `LIMIT`), so it's not required to store
reservation as a stream attribute, but explicitly calling `free` seems like
more correct way
- `BuildProbeJoinMetrics` -- at this moment CrossJoinExec lacks metrics
which could be exposed in `explain analyze` -- the counters from
`CrossJoinStream` has been moved to `BuildProbeJoinMetrics` structure -- it
could also be used in followups for both `NestedLoopJoinExec` and
`HashJoinExec` as they all share almost the same "build & probe" idea, so their
metrics could be similar.
# Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are
they covered by existing tests)?
-->
Test cases for normal cross join execution and asserting error in case of
overallocation attempt have been added
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api
change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
