sweb commented on pull request #8640: URL: https://github.com/apache/arrow/pull/8640#issuecomment-728805602
> Hi @sweb, I'm providing general comments, I'll look at this in detail over the days. > > I see that you're using `i128` as the backing type. One of the reasons that's prevented us from making progress on this, is not having a good BigDecimal impl in Rust to use. > The biggest hurdle will be converting `123.45f64` to decimals, as we'll need to do that for integration testing. > > On the JIRA itself, the plan was to add the type, then also: > > * add support on the IPC reader and writer > > * enable decimal types in integration teting > > > I'm fine with us doing the above as follow-ups, as they'd be quite involved. Thank you very much for your first feedback! I can try to create a second pull request for adding the IPC reader / writer after this one. I didn't think of it since I mainly use arrow as a processing layer after reading parquet files and never use the IPC parts. I have some ideas concerning the conversion from f64 to decimal, but I will try to find a reference implementation in the Python sources - maybe we can borrow some ideas from there. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
