sweb commented on pull request #8640:
URL: https://github.com/apache/arrow/pull/8640#issuecomment-729082645


   @jorgecarleitao could you check the following strange thing I cannot explain 
to myself:
   
   I added two additional asserts in `test_decimal_offsets` and 
`test_fixed_size_binary_offsets` (see latest commit, leading to 2 failing 
tests).
   
   ```
               let a = create_decimal_array(&[
               Some(8_887_000_000),
               None,
               None,
               Some(-8_887_000_000),
               None,
               None,
           ]);
           let b = create_decimal_array(&[
               Some(8_887_000_000),
               None,
               None,
               Some(15_887_000_000),
               None,
               None,
           ]);
   
           let a_slice = a.slice(3, 3);
           let b_slice = b.slice(3, 3);
           test_equal(&a_slice, &b_slice, false);
   ```
   
   From my current understanding, these slices should not be the same, since 
one is [-8887, None, None] and the other one is [15887, None, None]. However 
the test states that they are equal. Same for the fixed_binary test. Do you 
have an idea what I am missing? It is very likely that I do not really 
understand how the offsets work and that these checks should in fact evaluate 
to `true`.
   
   Thanks!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to