icexelloss commented on code in PR #34288:
URL: https://github.com/apache/arrow/pull/34288#discussion_r1114591126


##########
cpp/src/arrow/engine/substrait/function_test.cc:
##########
@@ -188,6 +188,12 @@ TEST(FunctionMapping, ValidCases) {
        {int8(), int8()},
        "-119",
        int8()},
+      {{kArrowSimpleExtensionFunctionsUri, "add_checked"},

Review Comment:
   I wonder if this also works for UDFs? e.g., if I register a Python UDF by 
name "my_func", I can also use the same `::arrow::compute::call` to invoke it 
via `kSimpleSubstraitToArrow` or is there more to it?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to