westonpace commented on code in PR #34288:
URL: https://github.com/apache/arrow/pull/34288#discussion_r1114827710
##########
cpp/src/arrow/engine/substrait/function_test.cc:
##########
@@ -188,6 +188,12 @@ TEST(FunctionMapping, ValidCases) {
{int8(), int8()},
"-119",
int8()},
+ {{kArrowSimpleExtensionFunctionsUri, "add_checked"},
Review Comment:
It should work for any scalar UDF used in a project node or filter node. It
would also work for aggregate UDFs (though these cannot be specified in python).
`::arrow::compute::call` is evaluated by looking up the function, by name,
in the function registry given to the plan. So the UDF will either need to be
added to the default function registry or the custom function registry will
need to be specified when the plan is run (I believe
pyarrow.substrait.run_query exposes this configuration property but, if not, we
can add it easily).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
